[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

[Farzon Lotfi via cfe-commits]

================
@@ -22,7 +22,7 @@ float test_dot_vector_size_mismatch(float3 p0, float2 p1) {
 
 float test_dot_builtin_vector_size_mismatch(float3 p0, float2 p1) {
   return __builtin_hlsl_dot(p0, p1);
-  // expected-error at -1 {{all arguments to '__builtin_hlsl_dot' must have vectors of the same type}}
+  // expected-error at -1 {{all arguments to '__builtin_hlsl_dot' must have the same type}}
----------------
farzonl wrote:

it is but consolidating to one diagnostic means changing the language here isn't an option anymore without having to update a bunch of other projects Sema error tests.

https://github.com/llvm/llvm-project/pull/83609