[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

[Greg Roth via cfe-commits]

================
@@ -5241,8 +5241,8 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) {
 
   // Note: if we get here one of the args is a scalar which
   // requires a VectorSplat on Arg0 or Arg1
-  S->Diag(BuiltinLoc, diag::err_vec_builtin_non_vector_all)
-      << TheCall->getDirectCallee()
+  S->Diag(BuiltinLoc, diag::err_vec_builtin_non_vector)
+      << TheCall->getDirectCallee() << /*all args*/ true
----------------
pow2clk wrote:

I appreciate the comment about what the parameter means, there is some inconsistency in how it's labeled. After this point, it's always `/*isMoretThanTwoArgs*/` which I think is better. 

https://github.com/llvm/llvm-project/pull/83609