[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading (PR #68986)

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 19 11:14:13 PDT 2023


dwblaikie wrote:

> > FWIW, I think we also saw, internally at Google, some significant and surprising (growth in sections, like .debug_loclists and .debug_gnu_pubnames/types) that were a bit surprising/not what I'd have expected of the original committed/reverted patch.
> > Could you run a clang build with/without this patch, and compare the two files using `bloaty` ( https://github.com/google/bloaty ) or similar - some comparison of the % growth of each section to see how these patches are affecting debug info size?
> > (patch itself sounds OK/looks good)
> 
> I haven't mentioned any significant change in the total debug info size. The full size of the debug info sections of clang executable file has increased by less than 1%. The size of the debug info sections of test-suite object files has also increased by 0,02% in total.

Hmm - we saw some much larger swings internally, but hopefully something just got confused... I may need to test/look into it in more detail.

https://github.com/llvm/llvm-project/pull/68986


More information about the cfe-commits mailing list