[clang] [sema] Improve -Wsign-compare (PR #65684)

[Aaron Ballman via cfe-commits]

=?utf-8?q?Félix?= Cloutier <fcloutier at apple.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/65684/clang at github.com>


https://github.com/AaronBallman commented:

Thank you for this! Overall, I like the improvements.

I think the note and the fix-it are helpful. I'm more comfortable with the note than I am the fix-it, however, because the fix-it could result in a change in behavior of the code that takes accidentally working code and makes it incorrect: https://godbolt.org/z/cbxr5vE6x

CC @cjdb 

https://github.com/llvm/llvm-project/pull/65684