[clang] [sema] Improve -Wsign-compare (PR #65684)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 6 10:44:54 PDT 2023


=?utf-8?q?F=C3=A9lix?= Cloutier <fcloutier at apple.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/65684/clang at github.com>


================
@@ -7237,8 +7237,12 @@ def warn_tautological_compare_value_range : Warning<
   InGroup<TautologicalValueRangeCompare>, DefaultIgnore;
 
 def warn_mixed_sign_comparison : Warning<
-  "comparison of integers of different signs: %0 and %1">,
-  InGroup<SignCompare>, DefaultIgnore;
+  "comparison of integers of different signs implicitly casts "
+  "%select{left|right}0-side operand from %1 to %2">, InGroup<SignCompare>,
----------------
AaronBallman wrote:

```suggestion
  "comparison of integers of different signs implicitly casts the "
  "%select{left|right}0 operand from %1 to %2">, InGroup<SignCompare>,
```
I don't think we usually say `left-side`, so slight rewording for consistency.

https://github.com/llvm/llvm-project/pull/65684


More information about the cfe-commits mailing list