[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload
Rainer Orth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 4 01:15:08 PDT 2023
ro added a comment.
In D155775#4652785 <https://reviews.llvm.org/D155775#4652785>, @AlexVlx wrote:
> In D155775#4652780 <https://reviews.llvm.org/D155775#4652780>, @dyung wrote:
>
>>
>> At this point, would it be easier to add a REQUIRES line for the target the test should support rather than just whack-a-mole for the targets it does not?
>
> Oh, it definitely would be MUCH easier to add a `REQUIRES` line, however I'd have had to have thought about that, which I did not, so thank you for the wake up call. I'll update this in a few minutes.
Unfortunately, this is still not done after almost a day, leaving quite a number of buildbots broken. Please fix or revert.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155775/new/
https://reviews.llvm.org/D155775
More information about the cfe-commits
mailing list