[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

Tue Oct 3 11:33:47 PDT 2023

AlexVlx added a comment.

In D155775#4652780 <https://reviews.llvm.org/D155775#4652780>, @dyung wrote:

> In D155775#4652773 <https://reviews.llvm.org/D155775#4652773>, @AlexVlx wrote:
>
>> In D155775#4652767 <https://reviews.llvm.org/D155775#4652767>, @dyung wrote:
>>
>>> Hi @AlexVlx, the test you added is failing on an linux bot, can you take a look and revert if you need time to investigate? It appears it has been failing for over 6 hours.
>>>
>>> https://lab.llvm.org/buildbot/#/builders/139/builds/50940
>>
>> This is another unsupported target (as is hexagon which is also failing), that I'll temporarily disable, but I admit to being actually confused as to why it's failing there, because the sequence it cannot find appears to be there. Thank you for flagging it.
>
> Note that this linux bot builds with the ps4 target as the default target.
>
> At this point, would it be easier to add a REQUIRES line for the target the test should support rather than just whack-a-mole for the targets it does not?

Oh, it definitely would be MUCH easier to add a `REQUIRES` line, however I'd have had to have thought about that, which I did not, so thank you for the wake up call. I'll update this in a few minutes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155775/new/

https://reviews.llvm.org/D155775