[clang] [clang][dataflow] Tweak styling of iteration tabs. (PR #67637)

via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 28 00:02:24 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

<details>
<summary>Changes</summary>

- On non-selected tabs, set cursor to 'pointer' to indicate they're clickable

- Selected tab shares the same background as the contents to emphasize that it's
  associated with that content. (Compare with Google Chrome or VS Code, which do
  this similarly.)

- Hovered-over tab becomes slightly brighter to indicate that clicking it will
  make it even brighter (again, Chrome does this in a similar way).


---
Full diff: https://github.com/llvm/llvm-project/pull/67637.diff


1 Files Affected:

- (modified) clang/lib/Analysis/FlowSensitive/HTMLLogger.css (+3-2) 


``````````diff
diff --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
index c8212df1f94b81a..0ac1902ea4651ec 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
@@ -64,15 +64,16 @@ section h2 {
   text-align: center;
 }
 #iterations .chooser:not(.iter-select).hover {
-  background-color: #aaa;
+  background-color: #ddd;
 }
 #iterations .iter-select {
   font-weight: bold;
-  background-color: #ccc;
 }
 #iterations .chooser:not(.iter-select) {
   text-decoration: underline;
   color: blue;
+  cursor: pointer;
+  background-color: #ccc;
 }
 
 code.filename {

``````````

</details>


https://github.com/llvm/llvm-project/pull/67637


More information about the cfe-commits mailing list