[clang] [clang][dataflow] Tweak styling of iteration tabs. (PR #67637)

via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 28 00:01:10 PDT 2023


https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/67637

- On non-selected tabs, set cursor to 'pointer' to indicate they're clickable

- Selected tab shares the same background as the contents to emphasize that it's
  associated with that content. (Compare with Google Chrome or VS Code, which do
  this similarly.)

- Hovered-over tab becomes slightly brighter to indicate that clicking it will
  make it even brighter (again, Chrome does this in a similar way).


>From fb57c6641cdb4f80df21a7c19d7a1c2fb7f04fdc Mon Sep 17 00:00:00 2001
From: Martin Braenne <mboehme at google.com>
Date: Thu, 28 Sep 2023 06:59:12 +0000
Subject: [PATCH] [clang][dataflow] Tweak styling of iteration tabs.

- On non-selected tabs, set cursor to 'pointer' to indicate they're clickable

- Selected tab shares the same background as the contents to emphasize that it's
  associated with that content. (Compare with Google Chrome or VS Code, which do
  this similarly.)

- Hovered-over tab becomes slightly brighter to indicate that clicking it will
  make it even brighter (again, Chrome does this in a similar way).
---
 clang/lib/Analysis/FlowSensitive/HTMLLogger.css | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
index c8212df1f94b81a..0ac1902ea4651ec 100644
--- a/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
+++ b/clang/lib/Analysis/FlowSensitive/HTMLLogger.css
@@ -64,15 +64,16 @@ section h2 {
   text-align: center;
 }
 #iterations .chooser:not(.iter-select).hover {
-  background-color: #aaa;
+  background-color: #ddd;
 }
 #iterations .iter-select {
   font-weight: bold;
-  background-color: #ccc;
 }
 #iterations .chooser:not(.iter-select) {
   text-decoration: underline;
   color: blue;
+  cursor: pointer;
+  background-color: #ccc;
 }
 
 code.filename {



More information about the cfe-commits mailing list