[clang-tools-extra] [clang-tidy] Add recursion protection in ExceptionSpecAnalyzer (PR #66810)

[Carlos Galvez via cfe-commits]

carlosgalvezp wrote:

To clarify, I'm not concerned about performance, but with code readability and maintainability. 

I realize the chain that I wrote above should not lead to recursion due to `SkipMethods::Yes` in the relevant call. I'd like to take a closer look at the problem, would you be able to share some of the stacktrace that shows how the recursion is happening? 

https://github.com/llvm/llvm-project/pull/66810