[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

[Ding Fei via Phabricator via cfe-commits]

danix800 added a comment.

In D158948#4642422 <https://reviews.llvm.org/D158948#4642422>, @haowei wrote:

> Looking at https://github.com/llvm/llvm-project/blob/37a20cc68f545647e614c5ba4ae311dc3fd277e9/clang/lib/Testing/CommandLineArgs.cpp#L47, this is were the unreachable code was hit. Is it the intended behavior?
>
> Shall I enable `ImportMatrixType` and disable `ImportOpenCLPipe` tests so we can update the GoogleTest in LLVM?

I'm not familiar with GoogleTest so I wasn't expecting this to happen.

To enabling `ImportOpenCLPipe` we might use `"-x", "cl", "-cl-no-stdinc", "-cl-std=CL2.0"` here <https://github.com/llvm/llvm-project/blob/37a20cc68f545647e614c5ba4ae311dc3fd277e9/clang/lib/Testing/CommandLineArgs.cpp#L47>.

See also https://reviews.llvm.org/D158872 for some extra context of both testing with `ImportMatrixType` and `ImportOpenCLPipe`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158948/new/

https://reviews.llvm.org/D158948