[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

Fri Sep 8 16:05:31 PDT 2023

haowei added a comment.

Hi I am working on updating GoogleTest in LLVM to v1.14.0 and during my local testing, I noticed that this patch added 2 new tests `ImportMatrixType` and `ImportOpenCLPipe` through `TEST_P` calls, however, both tests were not instantiated by `INSTANTIATE_TEST_SUITE_P` so they were not ran during `check-clang`. This will causes test failures when using GoogleTest v1.14.0 since it now explicitly fail when an `INSTANTIATE_TEST_SUITE_P` is not paired with an `TEST_P` I manually added

  INSTANTIATE_TEST_SUITE_P(ParameterizedTests, ImportMatrixType,
                           DefaultTestValuesForRunOptions);

  INSTANTIATE_TEST_SUITE_P(ParameterizedTests, ImportOpenCLPipe,
                           DefaultTestValuesForRunOptions);

to `ASTImporterTest.cpp` and reran the clang test and it failed with error message:

  [ RUN      ] ParameterizedTests/ImportOpenCLPipe.ImportPipeType/0
  Not implemented yet!
  UNREACHABLE executed at clang/lib/Testing/CommandLineArgs.cpp:47!
  Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
  0  ASTTests 0x00005565e9e71d18

  --
  exit: -6
  --

Looking at https://github.com/llvm/llvm-project/blob/37a20cc68f545647e614c5ba4ae311dc3fd277e9/clang/lib/Testing/CommandLineArgs.cpp#L47, this is were the unreachable code was hit. Is it the intended behavior?

Shall I enable `ImportMatrixType` and disable `ImportOpenCLPipe` tests so we can update the GoogleTest in LLVM?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158948/new/

https://reviews.llvm.org/D158948