[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

Mikael Holmén via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 6 21:51:35 PDT 2023


uabelho added inline comments.


================
Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336
-  case llvm::Triple::Minix:
-    AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3",
-                                "", "", "", triple);
----------------
brad wrote:
> uabelho wrote:
> > @brad :
> > I think this was the last use of the AddGnuCPlusPlusIncludePaths method, should we remove it now or is it likely it will be used again?
> > 
> > @brad :
> > I think this was the last use of the AddGnuCPlusPlusIncludePaths method, should we remove it now or is it likely it will be used again?
> 
> I noticed a function of the same name with the Darwin Driver.
Yeah Darwin defines and uses its own function with that name, but the one in InitHeaderSearch is unused since this patch.

I don't know anything about this, just noticed that gcc warns about it being unused.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158715/new/

https://reviews.llvm.org/D158715



More information about the cfe-commits mailing list