[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)

Phoebe Wang via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 6 02:23:21 PDT 2023


https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/65457:

m_x86_Features_Group always turn `mno-xxxx` into `-target-feature-xxxx`. In this case, we don't have `-gather/-scatter` but `+prefer-no-gather/scatter`.

>From be58af68f221bb65788e74f8cfe4952c1038ae70 Mon Sep 17 00:00:00 2001
From: Phoebe Wang <phoebe.wang at intel.com>
Date: Wed, 6 Sep 2023 17:10:01 +0800
Subject: [PATCH] [X86][Driver] Move mno-gather/mno-scatter from
 m_x86_Features_Group to m_Group. NFCI

m_x86_Features_Group always turn `mno-xxxx` into `-target-feature-xxxx`.
In this case, we don't have `-gather/-scatter` but `+prefer-no-gather/scatter`.
---
 clang/include/clang/Driver/Options.td | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index e6d8aed6aefc8d9..9a6e7e9929f5f2f 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -5846,9 +5846,9 @@ def mretpoline_external_thunk : Flag<["-"], "mretpoline-external-thunk">, Group<
 def mno_retpoline_external_thunk : Flag<["-"], "mno-retpoline-external-thunk">, Group<m_x86_Features_Group>;
 def mvzeroupper : Flag<["-"], "mvzeroupper">, Group<m_x86_Features_Group>;
 def mno_vzeroupper : Flag<["-"], "mno-vzeroupper">, Group<m_x86_Features_Group>;
-def mno_gather : Flag<["-"], "mno-gather">, Group<m_x86_Features_Group>,
+def mno_gather : Flag<["-"], "mno-gather">, Group<m_Group>,
                  HelpText<"Disable generation of gather instructions in auto-vectorization(x86 only)">;
-def mno_scatter : Flag<["-"], "mno-scatter">, Group<m_x86_Features_Group>,
+def mno_scatter : Flag<["-"], "mno-scatter">, Group<m_Group>,
                   HelpText<"Disable generation of scatter instructions in auto-vectorization(x86 only)">;
 } // let Flags = [TargetSpecific]
 



More information about the cfe-commits mailing list