[PATCH] D159383: [Headers] Remove musl-related comment about NULL

Rich Felker via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 5 14:46:52 PDT 2023


dalias added a comment.

To be clear, musl does not support this regardless of whether `#include_next` is being used "right" or not. The only supported thing is not mixing headers at all.

If Emscripten and wasi are using musl-based headers, it probably makes sense for these targets to do the same thing with include order as for musl targets. The practice of mixing responsibility for system headers between libc and the compiler is a very glibc+gcc specific legacy thing. Even on gcc, the BSD targets don't do this. Other targets might just because the gcc folks had a thing about "fixing" proprietary  unices' headers, but the standard open source non-GNU thing to do is to leave the headers entirely as the libc's responsibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159383/new/

https://reviews.llvm.org/D159383



More information about the cfe-commits mailing list