[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android
Shoaib Meenai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 31 13:22:51 PDT 2023
smeenai added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3108
+ SmallString<128> TargetDir(Path);
+ llvm::sys::path::append(TargetDir, Target, "c++", Version);
if (D.getVFS().exists(TargetDir))
----------------
rprichard wrote:
> Will the `Target` here have an Android API level suffix?
>
Yup, it will. D159293 and D158476 are the follow-ups to address that. The first one makes this call-site use the current fallback logic in the driver, and the second one extends that fallback logic to look for the next newest available API level if you don't have headers/libraries for the current API level.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159292/new/
https://reviews.llvm.org/D159292
More information about the cfe-commits
mailing list