[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

Ryan Prichard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 31 13:02:50 PDT 2023


rprichard added a comment.

This change looks like an improvement to me. The NDK currently puts the libc++ headers into the sysroot, but putting it in the usual toolchain include location seems better.



================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3108
+    SmallString<128> TargetDir(Path);
+    llvm::sys::path::append(TargetDir, Target, "c++", Version);
     if (D.getVFS().exists(TargetDir))
----------------
Will the `Target` here have an Android API level suffix?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159292/new/

https://reviews.llvm.org/D159292



More information about the cfe-commits mailing list