[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 13:03:35 PDT 2023


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, see below.



================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:869
                                bool IsThrownVarInScope) {
-  // Don't report an error if 'throw' is used in system headers.
-  if (!getLangOpts().CXXExceptions &&
+  const llvm::Triple T = Context.getTargetInfo().getTriple();
+  const bool IsOpenMPGPUTarget =
----------------



================
Comment at: clang/lib/Sema/SemaStmt.cpp:4474
                                   ArrayRef<Stmt *> Handlers) {
-  // Don't report an error if 'try' is used in system headers.
-  if (!getLangOpts().CXXExceptions &&
+  const llvm::Triple T = Context.getTargetInfo().getTriple();
+  const bool IsOpenMPGPUTarget =
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153924/new/

https://reviews.llvm.org/D153924



More information about the cfe-commits mailing list