[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

[Anton Rydahl via Phabricator via cfe-commits]

AntonRydahl marked 2 inline comments as done.
AntonRydahl added inline comments.


================
Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:11
+// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fexceptions %s -emit-llvm -S -verify=with -Wopenmp-target-exception -o - &> /dev/null
+// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device %s -emit-llvm -S -verify=with -Wopenmp-target-exception -o - &> /dev/null
+
----------------
jhuber6 wrote:
> jdoerfert wrote:
> > Can we use /dev/null? Do other tests use it? I would expect -analyze or sth instead.
> There's other tests, but I think that requires the shell or linux.
Thanks for the good point! It did not work with `-analyze` because I emitted the warnings during code generation. Now the warnings are emitted during semantic analysis, and `-analyze` can replace `-o - &> /dev/null`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153924/new/

https://reviews.llvm.org/D153924