[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

[Digger Lin via Phabricator via cfe-commits]

DiggerLin added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:566
 static bool checkAliasedGlobal(
-    DiagnosticsEngine &Diags, SourceLocation Location, bool IsIFunc,
-    const llvm::GlobalValue *Alias, const llvm::GlobalValue *&GV,
+    ASTContext &Context, DiagnosticsEngine &Diags, SourceLocation Location,
+    bool IsIFunc, const llvm::GlobalValue *Alias, const llvm::GlobalValue *&GV,
----------------
nit: change 
ASTContext &Context
-->
 const ASTContext &Context


================
Comment at: llvm/test/CodeGen/PowerPC/aix-common.ll:15
+; CHECK: LLVM ERROR: Aliases to common variables are not allowed on AIX:
+; CHECK:        Alias attribute for y is invalid because x is common.
----------------
CHECK: 
-->
CHECK-NEXT:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158739/new/

https://reviews.llvm.org/D158739