[PATCH] D158923: [clang-c] Visit ranged for initializer

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D158923#4619375 <https://reviews.llvm.org/D158923#4619375>, @kiloalphaindia wrote:

> Can we get this into release/17.x still?

Alas, but no -- 17.x changes are being limited to just fixes for critical issues/regressions at this point. (Once we start issuing release candidates, new features typically are not ported onto the release branch.)

Thank you for this! Can you also add a release note about the changes to `clang/docs/ReleaseNotes.rst`?



================
Comment at: clang/tools/libclang/CIndex.cpp:2834-2836
+  if (auto *init = S->getInit()) {
+    AddStmt(init);
+  }
----------------
`AddStmt()` already knows how to handle a null pointer.


================
Comment at: clang/unittests/libclang/LibclangTest.cpp:1142-1166
+  const char testSource[] = R"cpp(
+void fun()
+{
+    char text[] = "test";
+    for (int init = 0; auto x:text) {}
+}
+)cpp";
----------------
Just tiny nits, no functional changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158923/new/

https://reviews.llvm.org/D158923