[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 10:48:32 PDT 2023


PiotrZSL added a comment.

In D156616#4621975 <https://reviews.llvm.org/D156616#4621975>, @mikecrowe wrote:

> The removal of `c_str()` happens even without StrictMode set to True.

I still think we will be fine. There are not many situations when arguments need to be reorder. And most probably not many users will change default configuration.
LLVM 17 is already past RC3, this issue is not critical, nor a regression, user can always disable check, or just manually fix few problematic cases in code.
Additionally user could always take "main" version, and use it just to apply fixes from this check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156616/new/

https://reviews.llvm.org/D156616



More information about the cfe-commits mailing list