[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

Mon Aug 28 10:36:52 PDT 2023

mikecrowe added a comment.

In D156616#4621945 <https://reviews.llvm.org/D156616#4621945>, @PiotrZSL wrote:

> In D156616#4621914 <https://reviews.llvm.org/D156616#4621914>, @mikecrowe wrote:
>
>> @PiotrZSL, I think that this is quite an important fix since without it the check completely mangles the code. Should it be put in the 17.x release branch too?
>
> If issue happens only when StrictMode is set to True, then I wouldn't worry too much, and then this could wait for Clang 18 that is just half year away.

The removal of `c_str()` happens even without StrictMode set to True.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156616/new/

https://reviews.llvm.org/D156616