[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/test/SemaCXX/constexpr-string.cpp:681
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wconstant-conversion"
+namespace GH64876 {
----------------
erichkeane wrote:
> rather than suppress these, it makes sense to me to just mark them expected-warning.
It depends on the size of `size_t` whether I get this diagnostic or not. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158557/new/

https://reviews.llvm.org/D158557