[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Still think a codegen test for this example is VERY valuable here.



================
Comment at: clang/test/SemaCXX/constexpr-string.cpp:681
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wconstant-conversion"
+namespace GH64876 {
----------------
rather than suppress these, it makes sense to me to just mark them expected-warning.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158557/new/

https://reviews.llvm.org/D158557