[PATCH] D158409: [WebAssembly] Add multiple memories feature

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 08:50:53 PDT 2023


sbc100 added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4583
 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group<m_wasm_Features_Group>;
+def mmulti_memories : Flag<["-"], "mmulti-memories">, Group<m_wasm_Features_Group>;
+def mno_multi_memories : Flag<["-"], "mno-multi-memories">, Group<m_wasm_Features_Group>;
----------------
tlively wrote:
> Can we call this "multimemory" for consistency with "multivalue" above?
How about just `multi_memory`?    

In the past we have talked about "multi-table" and "multi-memory" without using the plural here and the proposal itself is names using the singular (https://github.com/WebAssembly/multi-memory).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158409/new/

https://reviews.llvm.org/D158409



More information about the cfe-commits mailing list