[PATCH] D158409: [WebAssembly] Add multiple memories feature

Thomas Lively via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 08:48:13 PDT 2023


tlively added a comment.

The other file to update here is clang/test/Driver/wasm-features.c. It looks like we haven't been as consistent about updating that one.



================
Comment at: clang/include/clang/Driver/Options.td:4583-4584
 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group<m_wasm_Features_Group>;
+def mmulti_memories : Flag<["-"], "mmulti-memories">, Group<m_wasm_Features_Group>;
+def mno_multi_memories : Flag<["-"], "mno-multi-memories">, Group<m_wasm_Features_Group>;
 def mexec_model_EQ : Joined<["-"], "mexec-model=">, Group<m_wasm_Features_Driver_Group>,
----------------
Can we call this "multimemory" for consistency with "multivalue" above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158409/new/

https://reviews.llvm.org/D158409



More information about the cfe-commits mailing list