[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

[Aiden Grossman via Phabricator via cfe-commits]

aidengrossman added a comment.

> I believe that /Ze has more in common with `-fms-compatibility` than `-fms-extensions`, but I could be wrong. Also, they may just be completely different things at this point. `/permissive` is closer in spirit to `-fms-compatibility`.

Better documentation at some point in the future would be helpful.

> In any case, if the has_builtin check works, I'd rather leave the macros alone. There could be unintended consequences, and I'm not fully convinced this is the right change.

Sounds good! That should also fix the aux triple issue with the `__cpuidex` patch as well (but not the underlying issue). Thank you for your insight and patience!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157334/new/

https://reviews.llvm.org/D157334