[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 17 15:28:32 PDT 2023


rnk added a comment.

> Also assuming that /Ze is similar to our -fms-extensions which I believe is the case, but not completely sure

I believe that /Ze has more in common with `-fms-compatibility` than `-fms-extensions`, but I could be wrong. Also, they may just be completely different things at this point. `/permissive` is closer in spirit to `-fms-compatibility`.

In any case, if the has_builtin check works, I'd rather leave the macros alone. There could be unintended consequences, and I'm not fully convinced this is the right change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157334/new/

https://reviews.llvm.org/D157334



More information about the cfe-commits mailing list