[PATCH] D158137: Change -ffp-model= related warn_drv_overriding_flag_option to warn_drv_overriding_option

Thu Aug 17 08:37:49 PDT 2023

MaskRay added a comment.

In D158137#4595234 <https://reviews.llvm.org/D158137#4595234>, @hans wrote:

>> Thanks! I agree. d9ad0681fad9a98f43d9baddb95d505b37153c48 (2013) renamed `warn_drv_overriding_t_option` to `warn_drv_overriding_flag_option`.
>> Perhaps the original name `warn_drv_overriding_t_option` should be restored.
>
> That change also started using it for overriding `/MD` and `/MT`. I think the intention then was to make the flag more general, but it forgot to rename the flag spelling. Perhaps the fix is really to s/overriding-t-option/overriding-option/ ? (If we're concerned about the interface change, we could retain an alias with the old spelling.)

`s/overriding-t-option/overriding-option/` sounds good. I'll change the patch accordingly, but keep the `warn_drv_overriding_option` name (Some uses are not related to boolean flags).
I wish that we keep -Woverriding-t-option and -Woverriding-option different.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158137/new/

https://reviews.llvm.org/D158137