[PATCH] D41425: [darwin][driver] Warn about mismatching -<os>-version-min rather than superfluous -<os>-version-min compiler option

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.
Herald added a subscriber: ributzka.
Herald added a project: All.


================
Comment at: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp:1545
+        std::string TargetArg = OSTarget->getAsString(Args, Opts);
+        getDriver().Diag(clang::diag::warn_drv_overriding_flag_option)
+            << OSVersionArg << TargetArg;
----------------
`warn_drv_overriding_flag_option` is in the group `-Woverriding-t-option` (D1290), which is for clang-cl `/T*` options.
I think we need a different diagnostic group for this purpose. I created D158137 to add `warn_drv_overriding_option`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41425/new/

https://reviews.llvm.org/D41425