[PATCH] D155081: Specify the developer policy around links to external resources

Tue Aug 15 08:11:39 PDT 2023

aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.

================
Comment at: llvm/docs/DeveloperPolicy.rst:349

-* If the patch has been reviewed, add a link to its review page, as shown
-  `here <https://www.llvm.org/docs/Phabricator.html#committing-a-change>`_.
----------------
aaron.ballman wrote:
> reames wrote:
> > Removing this item seems very off topic for the change description, and certainly hasn't been discussed in the linked thread.  Please add this back in a separate commit.
> > 
> > (To be clear, no objections to the overall change, just the removal of the phab link text.)
> Hmm, I thought this was obsoleted by the new text (it is covered by "other kinds of metadata"). That said, losing that link is definitely a regression, so thank you for pointing this out! I'll find a way to add it back in (either as a stand-alone bullet point or incorporated into the new text).
I restored the link in https://github.com/llvm/llvm-project/commit/a1562bbc63b49a70b39ba075d9a3332f50cea11d as part of the new bullet; please let me know if you have additional concerns.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155081/new/

https://reviews.llvm.org/D155081