[PATCH] D155081: Specify the developer policy around links to external resources
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 15 08:03:12 PDT 2023
aaron.ballman added inline comments.
================
Comment at: llvm/docs/DeveloperPolicy.rst:349
-* If the patch has been reviewed, add a link to its review page, as shown
- `here <https://www.llvm.org/docs/Phabricator.html#committing-a-change>`_.
----------------
reames wrote:
> Removing this item seems very off topic for the change description, and certainly hasn't been discussed in the linked thread. Please add this back in a separate commit.
>
> (To be clear, no objections to the overall change, just the removal of the phab link text.)
Hmm, I thought this was obsoleted by the new text (it is covered by "other kinds of metadata"). That said, losing that link is definitely a regression, so thank you for pointing this out! I'll find a way to add it back in (either as a stand-alone bullet point or incorporated into the new text).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155081/new/
https://reviews.llvm.org/D155081
More information about the cfe-commits
mailing list