[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

Justin Bogner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 14 03:39:09 PDT 2023


bogner added a comment.

I can't speak to which flags should be present in flang-new or not, but in principle this looks great. You'll need to update the patch to use the "ClangOption" spelling rather than "Default" of course, as discussed in https://reviews.llvm.org/D157151



================
Comment at: clang/lib/Driver/Driver.cpp:6473
     // TODO: Does flang really want *all* of the clang driver options?
     // We probably need to annotate more specifically.
+    return llvm::opt::Visibility(options::FlangOption);
----------------
We can remove the TODO comment with this change :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157837/new/

https://reviews.llvm.org/D157837



More information about the cfe-commits mailing list