[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

[Tom Eccles via Phabricator via cfe-commits]

tblah added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:6472-6473
   if (IsFlangMode()) {
     // TODO: Does flang really want *all* of the clang driver options?
     // We probably need to annotate more specifically.
+    return llvm::opt::Visibility(options::FlangOption);
----------------
I presume this TODO can go now?


================
Comment at: flang/test/Driver/target-cpu-features.f90:14
 ! Negative test. ARM cpu with x86 target.
-! RUN: not %flang --target=x86_64-linux-gnu -mcpu=cortex-a57 -c %s -### 2>&1 \
+! RUN: %flang --target=x86_64-linux-gnu -mcpu=cortex-a57 -c %s -### 2>&1 \
 ! RUN: | FileCheck %s -check-prefix=CHECK-NO-A57
----------------
Why doesn't this fail now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157837/new/

https://reviews.llvm.org/D157837