[PATCH] D157651: [RISCV] Rewrite CheckInvalidVLENandLMUL to avoid floating point.
Craig Topper via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Aug 12 11:01:02 PDT 2023
craig.topper updated this revision to Diff 549634.
craig.topper added a comment.
Revise coment, rename variable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157651/new/
https://reviews.llvm.org/D157651
Files:
clang/lib/Sema/SemaChecking.cpp
Index: clang/lib/Sema/SemaChecking.cpp
===================================================================
--- clang/lib/Sema/SemaChecking.cpp
+++ clang/lib/Sema/SemaChecking.cpp
@@ -4474,14 +4474,22 @@
assert((EGW == 128 || EGW == 256) && "EGW can only be 128 or 256 bits");
// LMUL * VLEN >= EGW
- uint64_t ElemSize = Type->isRVVType(32, false) ? 32 : 64;
- uint64_t ElemCount = Type->isRVVType(1) ? 1 :
- Type->isRVVType(2) ? 2 :
- Type->isRVVType(4) ? 4 :
- Type->isRVVType(8) ? 8 :
- 16;
- float Lmul = (float)(ElemSize * ElemCount) / llvm::RISCV::RVVBitsPerBlock;
- uint64_t MinRequiredVLEN = std::max(EGW / Lmul, (float)ElemSize);
+ unsigned ElemSize = Type->isRVVType(32, false) ? 32 : 64;
+ unsigned MinElemCount = Type->isRVVType(1) ? 1
+ : Type->isRVVType(2) ? 2
+ : Type->isRVVType(4) ? 4
+ : Type->isRVVType(8) ? 8
+ : 16;
+
+ unsigned EGS = EGW / ElemSize;
+ // If EGS is less than or equal to the minimum number of elements we're done.
+ if (EGS <= MinElemCount)
+ return false;
+
+ // We need vscale to be at least this value.
+ unsigned VScaleFactor = EGS / MinElemCount;
+ // Vscale is VLEN/RVVBitsPerBlock.
+ unsigned MinRequiredVLEN = VScaleFactor * llvm::RISCV::RVVBitsPerBlock;
std::string RequiredExt = "zvl" + std::to_string(MinRequiredVLEN) + "b";
if (!TI.hasFeature(RequiredExt))
return S.Diag(TheCall->getBeginLoc(),
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157651.549634.patch
Type: text/x-patch
Size: 1590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230812/cba97408/attachment.bin>
More information about the cfe-commits
mailing list