[PATCH] D157651: [RISCV] Rewrite CheckInvalidVLENandLMUL to avoid floating point.

Brandon Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 11 04:45:13 PDT 2023


4vtomat accepted this revision.
4vtomat added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: clang/lib/Sema/SemaChecking.cpp:4484
+  unsigned EGS = EGW / ElemSize;
+  // If EGS is more than our minimum number of elements we're done.
+  if (EGS <= ElemCount)
----------------
Does the `EGS` here mean the `ElemCount`?
If it does, can we change the `EGS` in the comment to other name, since when I first see this comment, I just thought the `EGS` here means the argument name lol~


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157651/new/

https://reviews.llvm.org/D157651



More information about the cfe-commits mailing list