[PATCH] D156948: [clang][modules] Add -Wsystem-headers-in-module=

Ian Anderson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 8 22:20:49 PDT 2023


iana accepted this revision.
iana added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticOptions.h:128
+  /// whether -Wsystem-headers is enabled on a per-module basis.
+  std::vector<std::string> SystemHeaderWarningsModules;
+
----------------
benlangmuir wrote:
> jansvoboda11 wrote:
> > Out of interest, is there an existing use-case for having multiple modules here, or is this just future-proofing?
> I'm not using it currently, but I think it makes sense to handle any number. You could have multiple such modules you're testing together.
I'd imagine you'd typically have Framework and Framework_Private in there


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156948/new/

https://reviews.llvm.org/D156948



More information about the cfe-commits mailing list