[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

Tue Aug 8 03:59:40 PDT 2023

ro added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193
     // Skip other prefixes once a GCC installation is found.
-    if (Version > VersionZero)
+    // Solaris GCC installations live in separate Prefixes per Version
+    // (/usr/gcc/<Version>) that arrive in directory order, so check all
----------------
MaskRay wrote:
> Adding a Solaris special case here seems strange.
> 
> Do you know what the typical `Prefixes` values are on Solaris? Is it possible to remove some elements as a special case for Solaris instead?
Agreed.  This patch in its current form is just meant as a stop-gap measure to unbreak basic Solaris functionality while avoiding to affect other targets.

I've described the value of `Prefixes` on Solaris in the Issue: its an array of `/usr/gcc/<N>` for each installed version of GCC, however in directory order and thus random.  The exact set is variable since every version can be installed or uninstalled at any time, old versions get deprecated and removed, and new ones added over time.

My fundamental problem here is that I haven't yet been able to reproduce the failure your original patch is meant to fix, so I don't really know what to guard against.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157275/new/

https://reviews.llvm.org/D157275