[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 7 19:58:02 PDT 2023


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193
     // Skip other prefixes once a GCC installation is found.
-    if (Version > VersionZero)
+    // Solaris GCC installations live in separate Prefixes per Version
+    // (/usr/gcc/<Version>) that arrive in directory order, so check all
----------------
Adding a Solaris special case here seems strange.

Do you know what the typical `Prefixes` values are on Solaris? Is it possible to remove some elements as a special case for Solaris instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157275/new/

https://reviews.llvm.org/D157275



More information about the cfe-commits mailing list