[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

[Takuya Shimizu via Phabricator via cfe-commits]

hazohelet added a comment.

In D152495#4566634 <https://reviews.llvm.org/D152495#4566634>, @aaron.ballman wrote:

> In D152495#4563520 <https://reviews.llvm.org/D152495#4563520>, @hazohelet wrote:
>
>> I reverted this change because it broke sanitizer buildbots.
>> https://lab.llvm.org/buildbot/#/builders/19/builds/18369
>> The cause of the errors here are relatively clear and I can speculatively replace `if (std::error_code EC = makeCanonical(Path))` with `if (makeCanonical(Path))`
>
> That changes makes sense to me.
>
>> https://lab.llvm.org/buildbot/#/builders/94/builds/15865
>> https://lab.llvm.org/buildbot/#/builders/240/builds/12947
>> These 2 are not clear for me, so I'll take time to find the cause.
>
> Neither of these are problems with your patch -- they're flaky tests in this case.

Thanks! I'll reland this patch with the unused `std::error_code` fix. I'll revert again if the same CI keeps failing for a few hours.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152495/new/

https://reviews.llvm.org/D152495