[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

Mon Aug 7 10:56:21 PDT 2023

aaron.ballman added a comment.

In D152495#4563520 <https://reviews.llvm.org/D152495#4563520>, @hazohelet wrote:

> I reverted this change because it broke sanitizer buildbots.
> https://lab.llvm.org/buildbot/#/builders/19/builds/18369
> The cause of the errors here are relatively clear and I can speculatively replace `if (std::error_code EC = makeCanonical(Path))` with `if (makeCanonical(Path))`

That changes makes sense to me.

> https://lab.llvm.org/buildbot/#/builders/94/builds/15865
> https://lab.llvm.org/buildbot/#/builders/240/builds/12947
> These 2 are not clear for me, so I'll take time to find the cause.

Neither of these are problems with your patch -- they're flaky tests in this case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152495/new/

https://reviews.llvm.org/D152495