[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

[Alex Voicu via Phabricator via cfe-commits]

AlexVlx added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5315
+      !GV->isThreadLocal() &&
+      !(getLangOpts().HIPStdPar && getLangOpts().CUDAIsDevice)) {
     if (D->getTLSKind() == VarDecl::TLS_Dynamic)
----------------
efriedma wrote:
> You can't just pretend a thread-local variable isn't thread-local.  If the intent here is that thread-local variables are illegal in device code, you need to figure out some way to produce a diagnostic.  (Maybe by generating a call to __stdpar_unsupported_threadlocal or something like that if code tries to refer to such a variable.)
Oh, this is actually an error that slipped through, I botched the diff it appears, I'll correct it, apologies.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155850/new/

https://reviews.llvm.org/D155850