[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5559
+    return EmitStdParUnsupportedBuiltin(this, FD);
+  else
+    ErrorUnsupported(E, "builtin function");
----------------
Else-after-return.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5315
+      !GV->isThreadLocal() &&
+      !(getLangOpts().HIPStdPar && getLangOpts().CUDAIsDevice)) {
     if (D->getTLSKind() == VarDecl::TLS_Dynamic)
----------------
You can't just pretend a thread-local variable isn't thread-local.  If the intent here is that thread-local variables are illegal in device code, you need to figure out some way to produce a diagnostic.  (Maybe by generating a call to __stdpar_unsupported_threadlocal or something like that if code tries to refer to such a variable.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155850/new/

https://reviews.llvm.org/D155850