[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces
Joseph Huber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 1 12:09:53 PDT 2023
jhuber6 added a comment.
In D156816#4551409 <https://reviews.llvm.org/D156816#4551409>, @Anastasia wrote:
> Why not to just use target address space and define it to some macro with desirable spelling?
>
> I don't think renaming OpenCL address space to something else makes sense. It might make more sense to just introduced different model of address spaces completely. But if you use OpenCL ones then it makes sense to have adequate naming so its documentation and etc can be located.
My issue is that these address spaces aren't really OpenCL specific, they describe a larger concept than the OpenCL language itself and we'd like to use that without needing to invoke the `opencl` name, since it's unrelated in this context.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156816/new/
https://reviews.llvm.org/D156816
More information about the cfe-commits
mailing list