[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D156816#4551409 <https://reviews.llvm.org/D156816#4551409>, @Anastasia wrote:

> Why not to just use target address space and define it to some macro with desirable spelling?

If you mean the numbered address spaces, that's the broken thing this is specifically trying to disallow. We probably shouldn't even allow you to use those numbers. The numbered versions are not treated equivalently, and don't have the same enforced semantic rules. For example __constant__ disallows storing to it, but address_space(4) does. The lack of casting rules is also an issue


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156816/new/

https://reviews.llvm.org/D156816