[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields
Ding Fei via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 1 10:18:52 PDT 2023
danix800 added inline comments.
================
Comment at: clang/include/clang/AST/Expr.h:2343-2344
-protected:
- /// Set FPFeatures in trailing storage, used only by Serialization
+ /// Set FPFeatures in trailing storage, used by Serialization & ASTImporter
void setStoredFPFeatures(FPOptionsOverride F) { getTrailingFPFeatures() = F; }
----------------
aaron.ballman wrote:
> Rather than make this a public API, would it instead make sense to add `friend class ASTNodeImporter;` at the end of the class?
Tested & confirmed, it's unnecessary to expose this method, `friend` is much better. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156201/new/
https://reviews.llvm.org/D156201
More information about the cfe-commits
mailing list