[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

Ding Fei via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 1 09:53:14 PDT 2023


danix800 added inline comments.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:8033
+TEST_P(ASTImporterOptionSpecificTestBase,
+       ImportCirularRefFieldsWithoutCorruptedRecordLayoutCacheTest) {
+  // Import sequence: A => A.b => B => B.f() => ... => UnaryOperator(&) => ...
----------------
balazske wrote:
> A small thing, `ImportCirularRefFieldsWithoutCorruptedRecordLayoutCache` (no `Test` ending) is the usual naming for these tests.
Thanks for reminding, I'll fix all testcases ending with `Test`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156201/new/

https://reviews.llvm.org/D156201



More information about the cfe-commits mailing list