[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:232
+      static_cast<int32_t>((F.classify() & FPClassArg).getZExtValue());
+  S.Stk.push<Integral<32, true>>(Integral<32, true>::from(Result));
+
----------------
tbaeder wrote:
> aaron.ballman wrote:
> > Shouldn't this be pushing an `int`? (e.g., might not be 32 bits) -- same for the other builtins, now that I look at them.
> Yes, this is also covered by https://reviews.llvm.org/D155568
Ah, bitten by the massive patch stack again. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155393/new/

https://reviews.llvm.org/D155393