[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 31 08:10:58 PDT 2023


tbaeder marked an inline comment as done.
tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:232
+      static_cast<int32_t>((F.classify() & FPClassArg).getZExtValue());
+  S.Stk.push<Integral<32, true>>(Integral<32, true>::from(Result));
+
----------------
aaron.ballman wrote:
> Shouldn't this be pushing an `int`? (e.g., might not be 32 bits) -- same for the other builtins, now that I look at them.
Yes, this is also covered by https://reviews.llvm.org/D155568


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155393/new/

https://reviews.llvm.org/D155393



More information about the cfe-commits mailing list